linux-kernel - Re: [PATCH] checkpatch: Add check for array allocator family argument order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <780c6d84dc1a90fb29ea56541ccd7510d14086ba.camel@perches.com>
Date:   Thu, 03 Nov 2022 21:09:55 -0700
From:   Joe Perches <joe@...ches.com>
To:     Liao Chang <liaochang1@...wei.com>, apw@...onical.com,
        dwaipayanray1@...il.com, lukas.bulwahn@...il.com,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, bagasdotme@...il.com,
        pbonzini@...hat.com
Subject: Re: [PATCH] checkpatch: Add check for array allocator family
 argument order

On Fri, 2022-11-04 at 12:00 +0800, Liao Chang wrote:
> These array allocator family are sometimes misused with the first and
> second arguments switchted.
> 
> Same issue with calloc, kvcalloc, kvmalloc_array etc.
> 
> Bleat if sizeof is the first argument.
> 
> Link: https://lkml.org/lkml/2022/11/3/668

You might use the -next version of checkpatch on this and find out
it's generally better to use lore links like:

https://lore.kernel.org/lkml/5374345c-7973-6a3c-d559-73bf4ac15079@redhat.com/

> Signed-off-by: Liao Chang <liaochang1@...wei.com>

Acked-by: Joe Perches <joe@...ches.com>

cheers, Joe

> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 1e5e66ae5a52..a9a9dc277cff 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -7128,7 +7128,7 @@ sub process {
>  		}
>  
>  # check for alloc argument mismatch
> -		if ($line =~ /\b((?:devm_)?(?:kcalloc|kmalloc_array))\s*\(\s*sizeof\b/) {
> +		if ($line =~ /\b((?:devm_)?((?:k|kv)?(calloc|malloc_array)(?:_node)?))\s*\(\s*sizeof\b/) {
>  			WARN("ALLOC_ARRAY_ARGS",
>  			     "$1 uses number as first arg, sizeof is generally wrong\n" . $herecurr);
>  		}