linux-kernel - Re: [PATCH] Revert "usb: dwc3: disable USB core PHY management"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221104012415.zgasv5hu5l5imslc@synopsys.com>
Date:   Fri, 4 Nov 2022 01:24:30 +0000
From:   Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To:     Johan Hovold <johan+linaro@...nel.org>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Stefan Agner <stefan@...er.ch>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] Revert "usb: dwc3: disable USB core PHY management"

On Thu, Nov 03, 2022, Johan Hovold wrote:
> This reverts commit 6000b8d900cd5f52fbcd0776d0cc396e88c8c2ea.
> 
> The offending commit disabled the USB core PHY management as the dwc3
> already manages the PHYs in question.
> 
> Unfortunately some platforms have started relying on having USB core
> also controlling the PHY and this is specifically currently needed on
> some Exynos platforms for PHY calibration or connected device may fail
> to enumerate.
> 
> The PHY calibration was previously handled in the dwc3 driver, but to
> work around some issues related to how the dwc3 driver interacts with
> xhci (e.g. using multiple drivers) this was moved to USB core by commits
> 34c7ed72f4f0 ("usb: core: phy: add support for PHY calibration") and
> a0a465569b45 ("usb: dwc3: remove generic PHY calibrate() calls").
> 
> The same PHY obviously should not be controlled from two different
> places, which for example do no agree on the PHY mode or power state
> during suspend, but as the offending patch was backported to stable,
> let's revert it for now.
> 
> Reported-by: Stefan Agner <stefan@...er.ch>
> Link: https://urldefense.com/v3/__https://lore.kernel.org/lkml/808bdba846bb60456adf10a3016911ee@agner.ch/__;!!A4F2R9G_pg!alHoICKQIGg3RelD-tXOswfNBGy3QtLU4e9jazfXshXj1WeYF8LMgybbqHDrfszazJ9ywa1BdVX0i8gewLUmrvz2_mxX$ 
> Fixes: 6000b8d900cd ("usb: dwc3: disable USB core PHY management")
> Cc: stable@...r.kernel.org
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>  drivers/usb/dwc3/host.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 

Acked-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>

Thanks,
Thinh