linux-kernel - Re: [PATCH] crypto/hisilicon: Add null judgment to the callback interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2TWpyynYMyStKRX@gondor.apana.org.au>
Date:   Fri, 4 Nov 2022 17:08:55 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     liulongfang <liulongfang@...wei.com>
Cc:     wangzhou1@...ilicon.com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto/hisilicon: Add null judgment to the callback
 interface

On Sat, Oct 29, 2022 at 09:25:18AM +0800, liulongfang wrote:
>
> The context of the problem may not have been clearly stated in the previous
> description.
> 
> This is a problem found in one of our real user scenarios:
> In this scenario of using an accelerator to perform encryption  services,
> it was originally intended to use the CPU to perform encryption services
> in synchronous mode (without loading the hardware device driver, and without
> registering the asynchronous callback function), but due to a deployment
> error, the Hisi hardware device driver was loaded into the system,
> this wrong operation causes the encryption service to call the device
> driver of the hisi hardware, but the hardware device driver executes the
> asynchronous mode, so the callback interface is called after the service
> is completed.
> This leads to this system calltrace problem.
> 
> The purpose of this patch is to ensure that the device does not appear
> calltrace in this abnormal situation.

I'm still having trouble understanding this.  Please give an
exact call-trace that triggers the callback with a NULL callback
pointer.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt