linux-kernel - Re: [PATCH] crypto/hisilicon: Add null judgment to the callback interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d914a099-06ef-acfe-f394-f4790a821598@huawei.com>
Date:   Mon, 7 Nov 2022 21:22:22 +0800
From:   liulongfang <liulongfang@...wei.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     <wangzhou1@...ilicon.com>, <linux-crypto@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto/hisilicon: Add null judgment to the callback
 interface

On 2022/11/4 17:08, Herbert Xu wrote:
> On Sat, Oct 29, 2022 at 09:25:18AM +0800, liulongfang wrote:
>>
>> The context of the problem may not have been clearly stated in the previous
>> description.
>>
>> This is a problem found in one of our real user scenarios:
>> In this scenario of using an accelerator to perform encryption  services,
>> it was originally intended to use the CPU to perform encryption services
>> in synchronous mode (without loading the hardware device driver, and without
>> registering the asynchronous callback function), but due to a deployment
>> error, the Hisi hardware device driver was loaded into the system,
>> this wrong operation causes the encryption service to call the device
>> driver of the hisi hardware, but the hardware device driver executes the
>> asynchronous mode, so the callback interface is called after the service
>> is completed.
>> This leads to this system calltrace problem.
>>
>> The purpose of this patch is to ensure that the device does not appear
>> calltrace in this abnormal situation.
> 
> I'm still having trouble understanding this.  Please give an
> exact call-trace that triggers the callback with a NULL callback
> pointer.
> 

What do you need is the log of this call trace?

Kernel log:
 Workqueue: 0000:76:00.0 qm_work_process [hisi_qm]
 pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
 pc : 0x0
 lr : sec_skcipher_callback+0x108/0x140 [hisi_sec2]
 sp : ffff80002cda3cb0
 x29: ffff80002cda3cb0 x28: ffff0020a9a56080 x27: ffff2040076a4800
 x26: 0000000000000000 x25: dead000000000100 x24: dead000000000122
 x23: ffff0020881eb4d0 x22: ffff0020960c6f00 x21: ffff0020881eb4b0
 x20: ffff0020881eb478 x19: ffff2040076a4880 x18: 000000000000001c
 x17: 00000000a3f246e1 x16: ffffb38bc5e73d40 x15: 000000006c63877d
 x14: 0000000000000000 x13: 0000000000000000 x12: ffff2040063b1dd0
 x11: ffff2040063b1da8 x10: ffff2040063b1da8 x9 : ffffb38b8da71f78
 x8 : ffff2040063b1dd0 x7 : 0000000000000000 x6 : ffff2040063b1fd0
 x5 : 0000000000000228 x4 : 0000000000000000 x3 : ffff00209ba33000
 x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff2040076a4820
 Call trace:
  0x0
  sec_req_cb+0xc8/0x254 [hisi_sec2]
  qm_work_process+0x1d8/0x330 [hisi_qm]
  process_one_work+0x1e0/0x450
  worker_thread+0x158/0x450
  kthread+0x118/0x120
  ret_from_fork+0x10/0x20
  Code: bad PC value
  ---[ end trace 0000000000000000 ]---

> Thanks,
> 
Thanks,
Longfang.