linux-kernel - Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Nov 2022 15:04:49 +0100
From:   jerome Neanne <jneanne@...libre.com>
To:     Lee Jones <lee@...nel.org>
Cc:     lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        nm@...com, kristo@...nel.org, dmitry.torokhov@...il.com,
        krzysztof.kozlowski+dt@...aro.org, catalin.marinas@....com,
        will@...nel.org, tony@...mide.com, vigneshr@...com,
        bjorn.andersson@...aro.org, shawnguo@...nel.org,
        geert+renesas@...der.be, dmitry.baryshkov@...aro.org,
        marcel.ziswiler@...adex.com, vkoul@...nel.org,
        biju.das.jz@...renesas.com, arnd@...db.de, jeff@...undy.com,
        afd@...com, khilman@...libre.com, narmstrong@...libre.com,
        msp@...libre.com, j-keerthy@...com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-input@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC



On 04/11/2022 14:56, Lee Jones wrote:
> On Fri, 04 Nov 2022, jerome Neanne wrote:
> 
>>
>>
>> On 31/10/2022 12:00, Lee Jones wrote:
>>>> diff --git a/include/linux/mfd/tps65219.h b/include/linux/mfd/tps65219.h
>>>> new file mode 100644
>>>> index 000000000000..2c1cf92e92ac
>>>> --- /dev/null
>>>> +++ b/include/linux/mfd/tps65219.h
>>
>>>> +/**
>>>> + * struct tps65219 - tps65219 sub-driver chip access routines
>>>> + *
>>>> + * Device data may be used to access the TPS65219 chip
>>>> + *
>>>> + * @dev MFD device
>>>> + * @regmap Regmap for accessing the device registers
>>>> + * @irq_data Regmap irq data used for the irq chip
>>>> + * @nb notifier block for the restart handler
>>>> + */
>>>
>>> This header needs work.
>> I'm not sure to get your point here. Just something like below to match
>> format or do you expect more:
>>
>> /**
>>   * struct tps65219 - tps65219 sub-driver chip access routines
>>   *
>>   * Device data may be used to access the TPS65219 chip
>>   *
>>   * @dev: MFD device
>>   * @regmap: Regmap for accessing the device registers
>>   * @irq_data: Regmap irq data used for the irq chip
>>   * @nb: notifier block for the restart handler
>>   */
>>
>>>
>>> Can you try an compile with W=1 please.
>> This raise one warning on mfd:
> 
> Is that before or after the header was fixed-up?
After the header was fixed-up.
> 
>> drivers/mfd/tps65219.c:28:12: warning: ‘tps65219_soft_shutdown’ defined but
>> not used [-Wunused-function]
>>     28 | static int tps65219_soft_shutdown(struct tps65219 *tps)
>>        |            ^~~~~~~~~~~~~~~~~~~~~~
>> soft_shutdown has been validated and is used in TI baseline even if not
>> hooked in upstream version further to this review:
>> https://lore.kernel.org/lkml/20220825150224.826258-5-msp@baylibre.com/
> 
> Will tps65219_soft_shutdown() be used?
> 
> I think it should be removed until it's utilised in Mainline.
> 
I'll remove then

Thanks for your feedback