lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 4 Nov 2022 19:01:04 -0500 From: Nishanth Menon <nm@...com> To: jerome Neanne <jneanne@...libre.com> CC: Lee Jones <lee@...nel.org>, <lgirdwood@...il.com>, <broonie@...nel.org>, <robh+dt@...nel.org>, <kristo@...nel.org>, <dmitry.torokhov@...il.com>, <krzysztof.kozlowski+dt@...aro.org>, <catalin.marinas@....com>, <will@...nel.org>, <tony@...mide.com>, <vigneshr@...com>, <bjorn.andersson@...aro.org>, <shawnguo@...nel.org>, <geert+renesas@...der.be>, <dmitry.baryshkov@...aro.org>, <marcel.ziswiler@...adex.com>, <vkoul@...nel.org>, <biju.das.jz@...renesas.com>, <arnd@...db.de>, <jeff@...undy.com>, <afd@...com>, <khilman@...libre.com>, <narmstrong@...libre.com>, <msp@...libre.com>, <j-keerthy@...com>, <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-input@...r.kernel.org>, <linux-omap@...r.kernel.org> Subject: Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC On 13:58-20221104, jerome Neanne wrote: > [...] > > > > > Can you try an compile with W=1 please. > This raise one warning on mfd: > drivers/mfd/tps65219.c:28:12: warning: ‘tps65219_soft_shutdown’ defined but > not used [-Wunused-function] > 28 | static int tps65219_soft_shutdown(struct tps65219 *tps) > | ^~~~~~~~~~~~~~~~~~~~~~ > soft_shutdown has been validated and is used in TI baseline even if not > hooked in upstream version further to this review: > https://lore.kernel.org/lkml/20220825150224.826258-5-msp@baylibre.com/ > > It was a TI requirement to implement it... > Let me know if you want me to remove this function or if we can keep it like > this. There are platforms without psci, correct? I think the comment was to drop the force override with system-power-controller property, if (!pm_power_off) { tps65219_i2c_client = client; pm_power_off = &tps65219_pm_power_off; } Could still be valid for such platforms, no? I do see that the capability that the PMIC has - which is software shutdown is a valid feature that we support in many different PMIC drivers. Is'nt the job of the driver to introduce the functionality in a manner that is appropriate to the OS framework? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Powered by blists - more mailing lists