linux-kernel - Re: [PATCH] rtla: Fix exit status when returning from calls to usage()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4639b19-94e3-2128-643e-6a3a44a1d944@kernel.org>
Date:   Fri, 4 Nov 2022 15:41:53 +0100
From:   Daniel Bristot de Oliveira <bristot@...nel.org>
To:     John Kacur <jkacur@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-trace-devel@...r.kernel.org,
        lkml <linux-kernel@...r.kernel.org>,
        Clark Williams <williams@...hat.com>,
        Chang Yin <cyin@...hat.com>
Subject: Re: [PATCH] rtla: Fix exit status when returning from calls to
 usage()

On 11/3/22 14:57, John Kacur wrote:
> rtla_usage(), osnoise_usage() and timerlat_usage() all exit with an
> error status

missing .

> However when these are called from help, they should exit with a
> non-error status.
> 
> Fix this by passing the exit status to the functions

missing .

> Note, although we remove the subsequent call to exit after calling
> usage, we leave it in at the end of a function to supress the compiler

suppress?

> warning "control reaches end of a non-void function"

missing .

Yep, that is a problem, and agree with the solution (I am already doing it
in the rv cmd line).

-- Daniel