linux-kernel - Re: [PATCH v1 1/1] gpiolib: of: Make use of device_match_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MeBM+iny7g4DEA-BgTWMnr_Bj1bmrpiKWGqp1nqkjbUDQ@mail.gmail.com>
Date:   Fri, 4 Nov 2022 16:11:19 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/1] gpiolib: of: Make use of device_match_of_node()

On Thu, Nov 3, 2022 at 9:29 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Make use of device_match_of_node() instead of open coding its
> functionality.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/gpio/gpiolib-of.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 52616848a37c..4b91e19366a8 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -85,7 +85,7 @@ static int of_gpiochip_match_node_and_xlate(struct gpio_chip *chip, void *data)
>  {
>         struct of_phandle_args *gpiospec = data;
>
> -       return chip->gpiodev->dev.of_node == gpiospec->np &&
> +       return device_match_of_node(&chip->gpiodev->dev, gpiospec->np) &&
>                                 chip->of_xlate &&
>                                 chip->of_xlate(chip, gpiospec, NULL) >= 0;
>  }
> --
> 2.35.1
>

Applied, thanks!

Bartosz