linux-kernel - Re: [PATCH] mtd: nand: raw: qcom_nandc: handle ret from parse with codeword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20221107162008.44113-1-miquel.raynal@bootlin.com>
Date:   Mon,  7 Nov 2022 17:20:08 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Christian Marangi <ansuelsmth@...il.com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-mtd@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org
Subject: Re: [PATCH] mtd: nand: raw: qcom_nandc: handle ret from parse with codeword_fixup

On Fri, 2022-10-21 at 16:53:04 UTC, Christian Marangi wrote:
> With use_codeword_fixup enabled, any return from
> mtd_device_parse_register gets overwritten. Aside from the clear bug, this
> is also problematic as a parser can EPROBE_DEFER and because this is not
> correctly handled, the nand is never rescanned later in the bootup
> process.
> 
> An example of this problem is when smem requires additional time to be
> probed and nandc use qcomsmempart as parser. Parser will return
> EPROBE_DEFER but in the current code this ret gets overwritten by
> qcom_nand_host_parse_boot_partitions and qcom_nand_host_init_and_register
> return 0.
> 
> Correctly handle the return code from mtd_device_parse_register so that
> any error from this function is not ignored.
> 
> Fixes: 862bdedd7f4b ("mtd: nand: raw: qcom_nandc: add support for unprotected spare data pages")
> Cc: stable@...r.kernel.org # v6.0+
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel