linux-kernel - Re: [PATCH] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt

Open Source and information security mailing list archives

Date:   Sun, 6 Nov 2022 19:58:37 -0500
From:   Peter Geis <pgwipeout@...il.com>
To:     Chen-Yu Tsai <wens@...nel.org>
Cc:     Heiko Stuebner <heiko@...ech.de>, Chen-Yu Tsai <wens@...e.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt

On Sun, Nov 6, 2022 at 11:15 AM Chen-Yu Tsai <wens@...nel.org> wrote:
>
> From: Chen-Yu Tsai <wens@...e.org>
>
> Ths PMIC's interrupt line is tied to GPIO0_A3. This is described
> correctly for the pinmux setting, but incorrectly for the interrupt.
>
> Correct the interrupt setting so that interrupts from the PMIC get
> delivered.
>
> Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")
> Signed-off-by: Chen-Yu Tsai <wens@...e.org>

Good catch, thanks!
Reviewed-by: Peter Geis <pgwipeout@...il.com>

> ---
>  arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> index 77b179cd20e7..b276eb0810c7 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> @@ -246,7 +246,7 @@ rk809: pmic@20 {
>                 compatible = "rockchip,rk809";
>                 reg = <0x20>;
>                 interrupt-parent = <&gpio0>;
> -               interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
> +               interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
>                 assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
>                 assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
>                 clock-names = "mclk";
> --
> 2.34.1
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives