linux-kernel - Re: [RESEND PATCH] arm64: dts: qcom: sm6125: fix SDHCI CQE reg names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221107214228.d6a635d3jrsfkyc2@SoMainline.org>
Date:   Mon, 7 Nov 2022 22:42:28 +0100
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Martin Botka <martin.botka@...ainline.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] arm64: dts: qcom: sm6125: fix SDHCI CQE reg names

On 2022-10-26 12:36:46, Krzysztof Kozlowski wrote:
> SM6125 comes with SDCC (SDHCI controller) v5, so the second range of
> registers is cqhci, not core.
> 
> Fixes: cff4bbaf2a2d ("arm64: dts: qcom: Add support for SM6125")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Not tested on hardware, but no practical impact is expected, because
> supports-cqe is not defined.

Thanks for this!  According to my downstream sources this reg is called
cmdq_mem, that's not core indeed.

Reviewed-by: Marijn Suijten <marijn.suijten@...ainline.org>
Tested-by: Marijn Suijten <marijn.suijten@...ainline.org> # Sony Xperia 10 II

And also according to my downstream sources, this SoC should support it.
When adding supports-cqe _together with your patch_:

    [    0.391950] sdhci_msm 4744000.mmc: mmc0: CQE init: success

I'll send a followup to that effect.  Thanks again for bringing this to
my attention!

- Marijn

> ---
>  arch/arm64/boot/dts/qcom/sm6125.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> index af49a748e511..24ee7c0c1195 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
> @@ -458,7 +458,7 @@ rpm_msg_ram: sram@...0000 {
>  		sdhc_1: mmc@...4000 {
>  			compatible = "qcom,sm6125-sdhci", "qcom,sdhci-msm-v5";
>  			reg = <0x04744000 0x1000>, <0x04745000 0x1000>;
> -			reg-names = "hc", "core";
> +			reg-names = "hc", "cqhci";
>  
>  			interrupts = <GIC_SPI 348 IRQ_TYPE_LEVEL_HIGH>,
>  				     <GIC_SPI 352 IRQ_TYPE_LEVEL_HIGH>;
> -- 
> 2.34.1
>