linux-kernel - Re: [PATCH 1/2] irqchip: loongarch-cpu: add DT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Nov 2022 15:04:27 +0800
From:   kernel test robot <lkp@...el.com>
To:     Liu Peibao <liupeibao@...ngson.cn>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Huacai Chen <chenhuacai@...nel.org>,
        WANG Xuerui <kernel@...0n.name>
Cc:     oe-kbuild-all@...ts.linux.dev, Jianmin Lv <lvjianmin@...ngson.cn>,
        Yinbo Zhu <zhuyinbo@...ngson.cn>,
        Liu Peibao <liupeibao@...ngson.cn>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] irqchip: loongarch-cpu: add DT support

Hi Liu,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/irq/core]
[also build test WARNING on robh/for-next linus/master v6.1-rc4 next-20221104]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Liu-Peibao/irqchip-loongarch-cpu-add-DT-support/20221107-103606
patch link:    https://lore.kernel.org/r/20221107023404.26730-1-liupeibao%40loongson.cn
patch subject: [PATCH 1/2] irqchip: loongarch-cpu: add DT support
config: loongarch-allyesconfig
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/10a355fa4bf4ae52f3889b1d4bec5be1143dd4e2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Liu-Peibao/irqchip-loongarch-cpu-add-DT-support/20221107-103606
        git checkout 10a355fa4bf4ae52f3889b1d4bec5be1143dd4e2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/irqchip/irq-loongarch-cpu.c:96:12: warning: no previous prototype for 'loongarch_cpu_irq_of_init' [-Wmissing-prototypes]
      96 | int __init loongarch_cpu_irq_of_init(struct device_node *of_node,
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +/loongarch_cpu_irq_of_init +96 drivers/irqchip/irq-loongarch-cpu.c

    94	
    95	#ifdef CONFIG_OF
  > 96	int __init loongarch_cpu_irq_of_init(struct device_node *of_node,
    97					struct device_node *parent)
    98	{
    99		cpuintc_handle = of_node_to_fwnode(of_node);
   100	
   101		irq_domain = irq_domain_create_linear(cpuintc_handle, EXCCODE_INT_NUM,
   102					&loongarch_cpu_intc_irq_domain_ops, NULL);
   103		if (!irq_domain)
   104			panic("Failed to add irqdomain for loongarch CPU");
   105	
   106		set_handle_irq(&handle_cpu_irq);
   107	
   108		return 0;
   109	}
   110	IRQCHIP_DECLARE(cpu_intc, "loongson,cpu-interrupt-controller",
   111						loongarch_cpu_irq_of_init);
   112	#endif
   113	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (323048 bytes)