linux-kernel - Re: [PATCH V2] rtla: Fix exit status when returning from calls to usage()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <624afa7a-3b9a-29a3-ab33-1b0efee83c19@redhat.com>
Date:   Mon, 7 Nov 2022 16:39:14 +0100
From:   Daniel Bristot de Oliveira <bristot@...hat.com>
To:     John Kacur <jkacur@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-trace-devel@...r.kernel.org,
        lkml <linux-kernel@...r.kernel.org>,
        Clark Williams <williams@...hat.com>,
        Chang Yin <cyin@...hat.com>
Subject: Re: [PATCH V2] rtla: Fix exit status when returning from calls to
 usage()

On 11/7/22 15:43, John Kacur wrote:
> rtla_usage(), osnoise_usage() and timerlat_usage() all exit with an
> error status.
> 
> However when these are called from help, they should exit with a
> non-error status.
> 
> Fix this by passing the exit status to the functions.
> 
> Note, although we remove the subsequent call to exit after calling
> usage, we leave it in at the end of a function to suppress the compiler
> warning "control reaches end of a non-void function".
> 
> Signed-off-by: John Kacur <jkacur@...hat.com>

Acked-by: Daniel Bristot de Oliveira <bristot@...nel.org>

Thanks!
-- Daniel