linux-kernel - Re: [PATCH v2 2/2] iio: addac: add AD74115 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202211072323.sBQEIPL0-lkp@intel.com>
Date:   Mon, 7 Nov 2022 23:39:36 +0800
From:   kernel test robot <lkp@...el.com>
To:     Cosmin Tanislav <demonsingur@...il.com>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        Cosmin Tanislav <cosmin.tanislav@...log.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        William Breathitt Gray <william.gray@...aro.org>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] iio: addac: add AD74115 driver

Hi Cosmin,

I love your patch! Yet something to improve:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linus/master v6.1-rc4 next-20221107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Cosmin-Tanislav/AD74115/20221103-174734
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20221103094436.2136698-3-demonsingur%40gmail.com
patch subject: [PATCH v2 2/2] iio: addac: add AD74115 driver
config: arm-randconfig-c002-20221106
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 2bbafe04fe785a9469bea5a3737f8d7d3ce4aca2)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/645566fcbcd39a1b546e8223d4af13fe902df3fc
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Cosmin-Tanislav/AD74115/20221103-174734
        git checkout 645566fcbcd39a1b546e8223d4af13fe902df3fc
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/iio/addac/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/iio/addac/ad74115.c:28:12: error: static declaration of 'iio_device_id' follows non-static declaration
   static int iio_device_id(struct iio_dev *indio_dev)
              ^
   include/linux/iio/iio.h:598:5: note: previous declaration is here
   int iio_device_id(struct iio_dev *indio_dev);
       ^
>> drivers/iio/addac/ad74115.c:30:20: error: no member named 'id' in 'struct iio_dev'
           return indio_dev->id;
                  ~~~~~~~~~  ^
   drivers/iio/addac/ad74115.c:1828:8: error: call to undeclared function 'devm_regulator_bulk_get_enable'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           ret = devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(regulator_names),
                 ^
   drivers/iio/addac/ad74115.c:1828:8: note: did you mean 'devm_regulator_bulk_get_const'?
   include/linux/regulator/consumer.h:247:18: note: 'devm_regulator_bulk_get_const' declared here
   int __must_check devm_regulator_bulk_get_const(
                    ^
   3 errors generated.


vim +30 drivers/iio/addac/ad74115.c

    26	
    27	/* 5.10 compatibility */
  > 28	static int iio_device_id(struct iio_dev *indio_dev)
    29	{
  > 30		return indio_dev->id;
    31	}
    32	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (220673 bytes)