lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Nov 2022 17:56:29 +0100 From: Konrad Dybcio <konrad.dybcio@...aro.org> To: Bjorn Andersson <quic_bjorande@...cinc.com>, Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org> Cc: Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 2/2] clk: qcom: Add SC8280XP display clock controller On 26/09/2022 22:38, Bjorn Andersson wrote: > From: Bjorn Andersson <bjorn.andersson@...aro.org> > > The Qualcomm SC8280XP platform has two display clock controller > instances, add support for these. Duplication between the two > implementations is reduced by reusing any constant data between the two > sets of clock data. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org> > Signed-off-by: Bjorn Andersson <quic_bjorande@...cinc.com> > --- Just a couple of bits: - Use lowercase hex in constants - I'm not sure I like hacking clocks up with magic writes.. this driver can and will be compiled as a module by default and that prevents a de-facto clean removal. Other than that: Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org> Konrad
Powered by blists - more mailing lists