linux-kernel - Re: [PATCH v2 2/2] arm64: dts: ti: Add support for phyBOARD-Electra-AM642

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2326682f-3b2b-0a2e-0601-2d79390ab92a@linaro.org>
Date:   Tue, 8 Nov 2022 19:28:04 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Wadim Egorov <W.Egorov@...tec.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     "upstream@...tec.de" <upstream@...tec.de>, "nm@...com" <nm@...com>,
        "vigneshr@...com" <vigneshr@...com>,
        "kristo@...nel.org" <kristo@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: Add support for
 phyBOARD-Electra-AM642

On 08/11/2022 19:25, Wadim Egorov wrote:
> 
>>> +	leds {
>>> +		compatible = "gpio-leds";
>>> +		pinctrl-names = "default";
>>> +		pinctrl-0 = <&user_leds_pins_default>;
>>> +
>>> +		led-1 {
>>> +			color = <LED_COLOR_ID_RED>;
>>> +			gpios = <&main_gpio0 15 GPIO_ACTIVE_HIGH>;
>>> +			linux,default-trigger = "mmc0";
>>> +			function = LED_FUNCTION_DISK;
>>> +		};
>>> +
>>> +		led-2 {
>>> +			color = <LED_COLOR_ID_GREEN>;
>>> +			gpios = <&main_gpio0 16 GPIO_ACTIVE_HIGH>;
>>> +			linux,default-trigger = "mmc1";
>>> +			function = LED_FUNCTION_DISK;
>>> +		};
>>> +	};
>>> +
>>> +	vcc_3v3_mmc: regulator-sd {
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
> 
> But what is wrong with the "regulator-sd" node name?

Uh, you are right, this is correct, my eyes are playing tricks on me...

Best regards,
Krzysztof