[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d721d484-84d3-f380-3bbc-43dad139bdee@linaro.org>
Date: Tue, 8 Nov 2022 22:15:11 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
robdclark@...il.com, quic_abhinavk@...cinc.com,
krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
quic_mkrishn@...cinc.com, linux-arm-msm@...r.kernel.org
Cc: Sean Paul <sean@...rly.run>, David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add
compatible strings for every current SoC
On 08/11/2022 13:46, Dmitry Baryshkov wrote:
> On 08/11/2022 02:56, Bryan O'Donoghue wrote:
>> Currently we do not differentiate between the various users of the
>> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one
>> compatible string but, the hardware does have some significant differences
>> in the number of clocks.
>>
>> To facilitate documenting the clocks add the following compatible strings
>>
>> - qcom,mdss-dsi-ctrl-apq8064
>
> Generic comment: I think we'd better follow the arm/qcom-soc.yaml and
> use qcom,soc-something as compat string. This would leave us with
> qcom,apq8064-dsi-ctrl
That's a requirement. Only existing patterns are allowed to continue,
but here all there is no such pattern.
Best regards,
Krzysztof
Powered by blists - more mailing lists