[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aeb59d3c-34d0-f00a-bfc3-524cd03acb71@linaro.org>
Date: Tue, 8 Nov 2022 15:46:50 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, robdclark@...il.com,
quic_abhinavk@...cinc.com, krzysztof.kozlowski+dt@...aro.org,
robh+dt@...nel.org, quic_mkrishn@...cinc.com,
linux-arm-msm@...r.kernel.org
Cc: Sean Paul <sean@...rly.run>, David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add
compatible strings for every current SoC
On 08/11/2022 02:56, Bryan O'Donoghue wrote:
> Currently we do not differentiate between the various users of the
> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one
> compatible string but, the hardware does have some significant differences
> in the number of clocks.
>
> To facilitate documenting the clocks add the following compatible strings
>
> - qcom,mdss-dsi-ctrl-apq8064
Generic comment: I think we'd better follow the arm/qcom-soc.yaml and
use qcom,soc-something as compat string. This would leave us with
qcom,apq8064-dsi-ctrl
I'm not sure if we want to follow the qcm2290 approach and encode the
DSI ctrl revision here (6g vs v2).
> - qcom,mdss-dsi-ctrl-msm8916
> - qcom,mdss-dsi-ctrl-msm8974
> - qcom,mdss-dsi-ctrl-msm8996
> - qcom,mdss-dsi-ctrl-sc7180
> - qcom,mdss-dsi-ctrl-sc7280
> - qcom,mdss-dsi-ctrl-sdm630
> - qcom,mdss-dsi-ctrl-sdm660
> - qcom,mdss-dsi-ctrl-sdm845
> - qcom,mdss-dsi-ctrl-sm8250
>
> Cc: Rob Clark <robdclark@...il.com>
> Cc: Abhinav Kumar <quic_abhinavk@...cinc.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> Cc: Sean Paul <sean@...rly.run>
> Cc: David Airlie <airlied@...il.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
> Cc: linux-arm-msm@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Cc: freedreno@...ts.freedesktop.org
> Cc: devicetree@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
> .../bindings/display/msm/dsi-controller-main.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index b35130a77b43e..9db3e63acda3d 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -17,6 +17,16 @@ properties:
> enum:
> - qcom,dsi-ctrl-6g-qcm2290
> - qcom,mdss-dsi-ctrl
> + - qcom,mdss-dsi-ctrl-apq8064
> + - qcom,mdss-dsi-ctrl-msm8916
> + - qcom,mdss-dsi-ctrl-msm8974
> + - qcom,mdss-dsi-ctrl-msm8996
> + - qcom,mdss-dsi-ctrl-sc7180
> + - qcom,mdss-dsi-ctrl-sc7280
> + - qcom,mdss-dsi-ctrl-sdm630
> + - qcom,mdss-dsi-ctrl-sdm660
> + - qcom,mdss-dsi-ctrl-sdm845
> + - qcom,mdss-dsi-ctrl-sm8250
>
> reg:
> maxItems: 1
--
With best wishes
Dmitry
Powered by blists - more mailing lists