linux-kernel - Re: [PATCH] phy: usb: sunplus: Fix memleak in update_disc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2n5fhFq4ozEzlBL@kroah.com>
Date:   Tue, 8 Nov 2022 07:38:54 +0100
From:   Greg KH <greg@...ah.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     vincent.sunplus@...il.com, vkoul@...nel.org, kishon@...nel.org,
        linux-usb@...r.kernel.org, linux-phy@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: usb: sunplus: Fix memleak in update_disc_vol()

On Tue, Nov 08, 2022 at 02:11:13PM +0800, YueHaibing wrote:
> 'otp_v' is allocated in nvmem_cell_read(), it should be freed
> before return.
> 
> Fixes: 99d9ccd97385 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/phy/sunplus/phy-sunplus-usb2.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c
> index e827b79f6d49..450cf8e6d7fb 100644
> --- a/drivers/phy/sunplus/phy-sunplus-usb2.c
> +++ b/drivers/phy/sunplus/phy-sunplus-usb2.c
> @@ -96,6 +96,7 @@ static int update_disc_vol(struct sp_usbphy *usbphy)
>  		set = *(otp_v + 1);
>  		set = (set << (sizeof(char) * 8)) | *otp_v;
>  		set = (set >> usbphy->disc_vol_addr_off) & J_DISC;
> +		kfree(otp_v);
>  	}
>  
>  	if (IS_ERR(otp_v) || set == 0)

How did you test this?

Just by looking at this tiny diff, this seems to be wrong, please fix
your tools and your review process to catch errors like this.

thanks,

greg k-h