linux-kernel - Re: [PATCH] selftests/bpf: Fix test_progs compilation failure in 32-bit arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52f848ad-fc12-c360-bb91-c1d9cd14853f@meta.com>
Date:   Mon, 7 Nov 2022 22:38:31 -0800
From:   Yonghong Song <yhs@...a.com>
To:     Yang Jihong <yangjihong1@...wei.com>, ast@...nel.org,
        daniel@...earbox.net, andrii@...nel.org, martin.lau@...ux.dev,
        song@...nel.org, yhs@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com,
        jolsa@...nel.org, mykolal@...com, shuah@...nel.org,
        sunyucong@...il.com, bpf@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/bpf: Fix test_progs compilation failure in
 32-bit arch



On 11/7/22 5:58 PM, Yang Jihong wrote:
> test_progs fails to be compiled in the 32-bit arch, log is as follows:
> 
>    test_progs.c:1013:52: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
>     1013 |                 sprintf(buf, "MSG_TEST_LOG (cnt: %ld, last: %d)",
>          |                                                  ~~^
>          |                                                    |
>          |                                                    long int
>          |                                                  %d
>     1014 |                         strlen(msg->test_log.log_buf),
>          |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          |                         |
>          |                         size_t {aka unsigned int}
> 
> Fix it.
> 
> Fixes: 91b2c0afd00c ("selftests/bpf: Add parallelism to test_progs")
> Signed-off-by: Yang Jihong <yangjihong1@...wei.com>

Acked-by: Yonghong Song <yhs@...com>