[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y2oJAlV3xwqmJK0o@infradead.org>
Date: Mon, 7 Nov 2022 23:45:06 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Ming Lei <ming.lei@...hat.com>
Cc: Jens Axboe <axboe@...nel.dk>, io-uring@...r.kernel.org,
linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-fsdevel@...r.kernel.org,
Miklos Szeredi <mszeredi@...hat.com>,
Stefan Hajnoczi <stefanha@...hat.com>,
ZiyangZhang <ZiyangZhang@...ux.alibaba.com>
Subject: Re: [RFC PATCH 3/4] io_uring/splice: support splice from
->splice_read to ->splice_read
On Thu, Nov 03, 2022 at 04:50:03PM +0800, Ming Lei wrote:
> The 1st ->splice_read produces buffer to the pipe of
> current->splice_pipe, and the 2nd ->splice_read consumes the buffer
> in this pipe.
This looks really ugly. I think you want Linus and Al to look over
it at very least.
Also, what is going to happen if your ->splice_read instance does not
support the flag to magically do something entirely different?
Powered by blists - more mailing lists