linux-kernel - Re: patches for staging:media drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf7dc5f6-acf3-73f0-b73b-d5707152190b@xs4all.nl>
Date:   Tue, 8 Nov 2022 10:35:54 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Deepak R Varma <drv@...lo.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-media@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-staging@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Dan Carpenter <error27@...il.com>,
        Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: patches for staging:media drivers

Hi Deepak,

On 11/8/22 09:10, Dan Carpenter wrote:
> On Mon, Nov 07, 2022 at 06:29:30PM +0100, Neil Armstrong wrote:
>> Hi,
>>
>> On 06/11/2022 11:52, Deepak R Varma wrote:
>>> Greetings to all.
>>> My name is Deepak R Varma and I was part of the recent Outreachy internship
>>> round. I learned during this program that patches for the media drivers were
>>> prohibited to be included in the Outreachy effort due to lack of bandwidth for
>>> the maintainers to respond on those.
>>>
>>> The Outreachy round is now over but I am continuing to work on code improvement
>>> and changes. I would like to know if it is okay for me to now identify
>>> opportunities in the media drivers and send patch proposal for your kind
>>> consideration. I intend to send couple of Coccinelle identified code
>>> improvements as patches.
>>>
>>> Please let me know.
>>
>> I won't say no but since the media maintainers will need to apply them,
>> the problem is the same.
> 
> Yeah.  Me either.  Those rules are for Outreachy so they don't apply to
> anyone else, but at the same time no one is going to Ack your patches
> without seeing them and especially for a subsystem they don't maintain.
> 
> I always try to think about if maintainers will want my patches.  Like
> I sometimes see people returning -1 instead of -ENOMEM but, you know,
> unless it reaches user space it's not technically a bug.  You can't go
> around fixing everyone's bad taste.  But everyone likes bug fixes.
> 
> regards,
> dan carpenter
> 

I don't mind taking patches for media staging drivers as long as:

1) they are not for atomisp, and
2) they are not for deprecated drivers (drivers/staging/media/deprecated/)

Regards,

	Hans