[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdb5NzUcnu6yK6t9CUPVb=FSpSJdWOwHVbJqq5FxapT_RA@mail.gmail.com>
Date: Tue, 8 Nov 2022 14:02:50 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Jim Liu <jim.t90615@...il.com>
Cc: JJLIU0@...oton.com, KWLIU@...oton.com, brgl@...ev.pl,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, openbmc@...ts.ozlabs.org
Subject: Re: [PATCH v2 1/3] gpio:gpio-npcm-sgpio: Add Nuvoton sgpio driver
Hi Jim!
thanks for your patch!
On Tue, Nov 8, 2022 at 10:29 AM Jim Liu <jim.t90615@...il.com> wrote:
> Add Nuvoton BMC sgpio driver support.
>
> Signed-off-by: Jim Liu <JJLIU0@...oton.com>
> ---
> Changes for v2:
> - add prefix
> - write the enum values in all capitals
> - remove _init in npcm_sgpio_probe
Overall this looks very good.
But:
> + u8 nin_sgpio;
> + u8 nout_sgpio;
These seem to be software constructs, for which you also add
custom device tree bindings.
The purpose seems to be an extra layer of protection, such as
blocking a user from setting some GPIOs as input or output.
I think you should just remove this, the GPIO driver is already
sufficiently low level without the need of protecting the users
from themselves.
Yours,
Linus Walleij
Powered by blists - more mailing lists