[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJZ5v0j3xwDKJig5OMkW208vxE3a-9_A2v06NDU4HRYpy4gZ5w@mail.gmail.com>
Date: Tue, 8 Nov 2022 15:54:58 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
linux-rtc@...r.kernel.org, Linux ACPI <linux-acpi@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
Linux PM <linux-pm@...r.kernel.org>,
Zhang Rui <rui.zhang@...el.com>,
Alessandro Zummo <a.zummo@...ertech.it>
Subject: Re: [PATCH v1 5/5] rtc: rtc-cmos: Disable ACPI RTC event on removal
On Mon, Nov 7, 2022 at 10:28 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Mon, Nov 07, 2022 at 09:03:06PM +0100, Rafael J. Wysocki wrote:
>
> ...
>
> > +static inline void acpi_rtc_event_cleanup(void)
> > +{
> > + if (!acpi_disabled)
>
> Btw, other functions look like using
>
> if (acpi_disabled)
> return;
>
> pattern. Maybe here the same for the sake of consistency?
>
> > + acpi_remove_fixed_event_handler(ACPI_EVENT_RTC, rtc_handler);
> > +}
>
Well, it is more lines of code, but whatever.
Powered by blists - more mailing lists