linux-kernel - Re: [PATCH v7 01/28] media: sun6i-csi: Add bridge v4l2 subdev with port management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Nov 2022 02:23:59 +0800
From:   kernel test robot <lkp@...el.com>
To:     Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        Yong Deng <yong.deng@...ewell.com>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v7 01/28] media: sun6i-csi: Add bridge v4l2 subdev with
 port management

Hi Paul,

I love your patch! Perhaps something to improve:

[auto build test WARNING on media-tree/master]
[also build test WARNING on soc/for-next linus/master v6.1-rc4 next-20221109]
[cannot apply to sailus-media-tree/streams]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Paul-Kocialkowski/Allwinner-A31-A83T-MIPI-CSI-2-and-A31-ISP-CSI-Rework/20221104-003518
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20221103163113.245462-2-paul.kocialkowski%40bootlin.com
patch subject: [PATCH v7 01/28] media: sun6i-csi: Add bridge v4l2 subdev with port management
config: arm64-allyesconfig
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 463da45892e2d2a262277b91b96f5f8c05dc25d0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/d26de0b15ad9da72e89a53abb74503a11cc6a1b9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Paul-Kocialkowski/Allwinner-A31-A83T-MIPI-CSI-2-and-A31-ISP-CSI-Rework/20221104-003518
        git checkout d26de0b15ad9da72e89a53abb74503a11cc6a1b9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/gpio/ drivers/gpu/drm/ drivers/media/platform/sunxi/sun6i-csi/ drivers/thermal/intel/ drivers/usb/gadget/udc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c:272:2: warning: variable 'enabled' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
           default:
           ^~~~~~~
   drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c:279:25: note: uninitialized use occurs here
                                        remote_subdev, enabled);
                                                       ^~~~~~~
   drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c:266:14: note: initialize the variable 'enabled' to silence this warning
           bool enabled;
                       ^
                        = 0
   1 warning generated.


vim +/enabled +272 drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c

   253	
   254	static int
   255	sun6i_csi_bridge_notifier_bound(struct v4l2_async_notifier *notifier,
   256					struct v4l2_subdev *remote_subdev,
   257					struct v4l2_async_subdev *async_subdev)
   258	{
   259		struct sun6i_csi_device *csi_dev =
   260			container_of(notifier, struct sun6i_csi_device,
   261				     bridge.notifier);
   262		struct sun6i_csi_bridge_async_subdev *bridge_async_subdev =
   263			container_of(async_subdev, struct sun6i_csi_bridge_async_subdev,
   264				     async_subdev);
   265		struct sun6i_csi_bridge_source *source = bridge_async_subdev->source;
   266		bool enabled;
   267	
   268		switch (source->endpoint.base.port) {
   269		case SUN6I_CSI_PORT_PARALLEL:
   270			enabled = true;
   271			break;
 > 272		default:
   273			break;
   274		}
   275	
   276		source->subdev = remote_subdev;
   277	
   278		return sun6i_csi_bridge_link(csi_dev, SUN6I_CSI_BRIDGE_PAD_SINK,
   279					     remote_subdev, enabled);
   280	}
   281	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (362032 bytes)