linux-kernel - Re: [PATCH] iommu/arm-smmu-v3: Restore prints in arm_smmu_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2v1x6F31X6F/VHS@Asurada-Nvidia>
Date:   Wed, 9 Nov 2022 10:47:35 -0800
From:   Nicolin Chen <nicolinc@...dia.com>
To:     Jason Gunthorpe <jgg@...dia.com>
CC:     <will@...nel.org>, <joro@...tes.org>,
        <linux-kernel@...r.kernel.org>, <iommu@...ts.linux.dev>,
        <linux-arm-kernel@...ts.infradead.org>, <robin.murphy@....com>
Subject: Re: [PATCH] iommu/arm-smmu-v3: Restore prints in
 arm_smmu_attach_dev()

On Wed, Nov 09, 2022 at 09:11:53AM -0400, Jason Gunthorpe wrote:
> On Tue, Nov 08, 2022 at 11:07:13PM -0800, Nicolin Chen wrote:
> > The prints for incompatible failures in arm_smmu_attach_dev() might be
> > still useful for error diagnosis. As VFIO and IOMMUFD would do testing
> > attach() call, having previous dev_err() isn't ideal either.
> > 
> > Add the prints back using dev_dbg().
> > 
> > Suggested-by: Will Deacon <will@...nel.org>
> > Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
> > ---
> >  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> 
> You should probably include a fixes line
> 
> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Just sent a v2 adding "Fixes" and "Reviewed-by". Thanks!