linux-kernel - Re: [PATCH 1/2] bfq: fix waker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166802322145.66062.9011104820940557467.b4-ty@kernel.dk>
Date:   Wed, 09 Nov 2022 12:47:01 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Khazhismel Kumykov <khazhy@...omium.org>,
        Paolo Valente <paolo.valente@...aro.org>
Cc:     Khazhismel Kumykov <khazhy@...gle.com>,
        linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>,
        linux-block@...r.kernel.org, Yu Kuai <yukuai1@...weicloud.com>
Subject: Re: [PATCH 1/2] bfq: fix waker_bfqq inconsistency crash

On Tue, 8 Nov 2022 10:10:29 -0800, Khazhismel Kumykov wrote:
> This fixes crashes in bfq_add_bfqq_busy due to waker_bfqq being NULL,
> but woken_list_node still being hashed. This would happen when
> bfq_init_rq() expects a brand new allocated queue to be returned from
> bfq_get_bfqq_handle_split() and unconditionally updates waker_bfqq
> without resetting woken_list_node. Since we can always return oom_bfqq
> when attempting to allocate, we cannot assume waker_bfqq starts as NULL.
> 
> [...]

Applied, thanks!

[1/2] bfq: fix waker_bfqq inconsistency crash
      commit: a1795c2ccb1e4c49220d2a0d381540024d71647c
[2/2] bfq: ignore oom_bfqq in bfq_check_waker
      commit: 99771d73ff4539f2337b84917f4792abf0d8931b

Best regards,
-- 
Jens Axboe