[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221109172537.0c48f66c@booty>
Date: Wed, 9 Nov 2022 17:25:37 +0100
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Sowjanya Komatineni <skomatineni@...dia.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Hans Verkuil <hverkuil-cisco@...all.nl>,
Dmitry Osipenko <digetx@...il.com>
Cc: linux-media@...r.kernel.org, linux-tegra@...r.kernel.org,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Richard Leitner <richard.leitner@...data.com>
Subject: Re: [PATCH 23/23] staging: media: tegra-video: add tegra20 variant
On Wed, 9 Nov 2022 15:18:52 +0100
luca.ceresoli@...tlin.com wrote:
> +static int tegra20_vi_enable(struct tegra_vi *vi, bool on)
> +{
> + /* from arch/arm/mach-tegra/iomap.h */
> + const phys_addr_t TEGRA_APB_MISC_BASE = 0x70000000;
> + const unsigned long reg_offset = 0x42c;
> + void __iomem *apb_misc;
> + u32 val;
> +
> + apb_misc = ioremap(TEGRA_APB_MISC_BASE, PAGE_SIZE);
> + if (!apb_misc)
> + apb_misc = ERR_PTR(-ENOENT);
> + if (IS_ERR(apb_misc))
> + return dev_err_probe(vi->dev, PTR_ERR(apb_misc), "cannot access APB_MISC");
> +
> + val = readl(apb_misc + reg_offset);
> + writel(val | (!!on), apb_misc + reg_offset);
Sorry, there is a mistake here, the bit should be set to 0 when
on==false, but this code does not do that. This will be fixed in v2.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists