linux-kernel - Re: [PATCH v2 1/2] iio: imu: inv_icm42600: Add support for icm42631

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <FR3P281MB1757D6533D9544FB0B1717FDCE019@FR3P281MB1757.DEUP281.PROD.OUTLOOK.COM>
Date:   Thu, 10 Nov 2022 19:47:38 +0000
From:   Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
To:     Jay Greco <grecojay@...zon.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
CC:     "jorcrous@...zon.com" <jorcrous@...zon.com>,
        Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] iio: imu: inv_icm42600: Add support for icm42631

Hello Jay,

looks good, thanks for the patch.

Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>

Thanks,
JB


From: Jay Greco <grecojay@...zon.com>
Sent: Thursday, November 10, 2022 20:29
To: linux-iio@...r.kernel.org <linux-iio@...r.kernel.org>
Cc: jorcrous@...zon.com <jorcrous@...zon.com>; Jay Greco <grecojay@...zon.com>; Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>; Jonathan Cameron <jic23@...nel.org>; Lars-Peter Clausen <lars@...afoo.de>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>
Subject: [PATCH v2 1/2] iio: imu: inv_icm42600: Add support for icm42631 
 
 CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe.

Add the required WHOAMI and device_id definitions to support the
icm42631.

Signed-off-by: Jay Greco <grecojay@...zon.com>
---

(no changes since v1)

 drivers/iio/imu/inv_icm42600/inv_icm42600.h      | 2 ++
 drivers/iio/imu/inv_icm42600/inv_icm42600_core.c | 5 +++++
 drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c  | 3 +++
 drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c  | 3 +++
 4 files changed, 13 insertions(+)

diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600.h b/drivers/iio/imu/inv_icm42600/inv_icm42600.h
index 3d91469beccb..0e290c807b0f 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600.h
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600.h
@@ -22,6 +22,7 @@ enum inv_icm42600_chip {
         INV_CHIP_ICM42602,
         INV_CHIP_ICM42605,
         INV_CHIP_ICM42622,
+       INV_CHIP_ICM42631,
         INV_CHIP_NB,
 };
 
@@ -303,6 +304,7 @@ struct inv_icm42600_state {
 #define INV_ICM42600_WHOAMI_ICM42602                    0x41
 #define INV_ICM42600_WHOAMI_ICM42605                    0x42
 #define INV_ICM42600_WHOAMI_ICM42622                    0x46
+#define INV_ICM42600_WHOAMI_ICM42631                   0x5C
 
 /* User bank 1 (MSB 0x10) */
 #define INV_ICM42600_REG_SENSOR_CONFIG0                 0x1003
diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_core.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_core.c
index ca85fccc9839..12952739f749 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600_core.c
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_core.c
@@ -87,6 +87,11 @@ static const struct inv_icm42600_hw inv_icm42600_hw[INV_CHIP_NB] = {
                 .name = "icm42622",
                 .conf = &inv_icm42600_default_conf,
         },
+       [INV_CHIP_ICM42631] = {
+               .whoami = INV_ICM42600_WHOAMI_ICM42631,
+               .name = "icm42631",
+               .conf = &inv_icm42600_default_conf,
+       },
 };
 
 const struct iio_mount_matrix *
diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c
index d4a692b838d0..38c36a655167 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c
@@ -84,6 +84,9 @@ static const struct of_device_id inv_icm42600_of_matches[] = {
         }, {
                 .compatible = "invensense,icm42622",
                 .data = (void *)INV_CHIP_ICM42622,
+       }, {
+               .compatible = "invensense,icm42631",
+               .data = (void *)INV_CHIP_ICM42631,
         },
         {}
 };
diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c
index e6305e5fa975..6a85c12d38bd 100644
--- a/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c
+++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c
@@ -80,6 +80,9 @@ static const struct of_device_id inv_icm42600_of_matches[] = {
         }, {
                 .compatible = "invensense,icm42622",
                 .data = (void *)INV_CHIP_ICM42622,
+       }, {
+               .compatible = "invensense,icm42631",
+               .data = (void *)INV_CHIP_ICM42631,
         },
         {}
 };
-- 
2.37.1