linux-kernel - Re: [PATCH] mm: Make some folio and page function arguments const and use bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y21ZLhbRDv1TKMR6@casper.infradead.org>
Date:   Thu, 10 Nov 2022 20:03:58 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: Make some folio and page function arguments const
 and use bool

On Thu, Nov 10, 2022 at 05:29:28PM +0000, David Howells wrote:
> Mark the folio* argument to some of the folio accessor functions as a const
> pointer and similarly make some page* arguments to some page functions
> const.

I think the build bots are going to whinge.

#ifdef CONFIG_DEBUG_VM_PGFLAGS
#define VM_BUG_ON_PGFLAGS(cond, page) VM_BUG_ON_PAGE(cond, page)

#define VM_BUG_ON_PAGE(cond, page)                                      \
        do {                                                            \
                if (unlikely(cond)) {                                   \
                        dump_page(page, "VM_BUG_ON_PAGE(" __stringify(cond)")");

void dump_page(struct page *page, const char *reason);

I've looked at making dump_page() take a const struct page * in the past,
but it's a lot of work.

Do you really need this or is this a Friday afternoon project?