linux-kernel - Re: [PATCH v10 1/2] thermal: loongson-2: add thermal management support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d975ae16-58b8-a844-7ffd-7fa06159311c@wanadoo.fr>
Date:   Thu, 10 Nov 2022 07:01:38 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Yinbo Zhu <zhuyinbo@...ngson.cn>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     zhanghongchen <zhanghongchen@...ngson.cn>,
        Liu Peibao <liupeibao@...ngson.cn>
Subject: Re: [PATCH v10 1/2] thermal: loongson-2: add thermal management
 support

Le 09/11/2022 à 09:09, Yinbo Zhu a écrit :
> Hi Rafael J.Wysocki,
> 
> I just have a verified on your tree about my patch again, it is okay,
> if no other proplems, please help merge it to your tree and sync it to 
> linux mainline tree.
> 
> Thanks,
> Yinbo.
> 

Hi,

I've sent a few nits on v10, that you are obviously free to take into 
account or not.

However, one of these comments is about thermal_add_hwmon_sysfs() vs 
devm_thermal_add_hwmon_sysfs() in loongson2_thermal_probe().

IMHO, if I'm correct, at least this comment should be fixed.

CJ