[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20221110060313.16303-1-linma@zju.edu.cn>
Date: Thu, 10 Nov 2022 14:03:13 +0800
From: Lin Ma <linma@....edu.cn>
To: axboe@...nel.dk, asml.silence@...il.com, io-uring@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: Lin Ma <linma@....edu.cn>
Subject: [PATCH v1] io_uring: remove outdated comments of caching
Previous commit 13a99017ff19 ("io_uring: remove events caching
atavisms") entirely removes the events caching optimization introduced
by commit 81459350d581 ("io_uring: cache req->apoll->events in
req->cflags"). Hence the related comment should also be removed to avoid
misunderstanding.
Fixes: 13a99017ff19 ("io_uring: remove events caching atavisms")
Signed-off-by: Lin Ma <linma@....edu.cn>
---
io_uring/poll.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/io_uring/poll.c b/io_uring/poll.c
index 0d9f49c575e0..74ba910c1f22 100644
--- a/io_uring/poll.c
+++ b/io_uring/poll.c
@@ -310,12 +310,7 @@ static void io_apoll_task_func(struct io_kiocb *req, bool *locked)
static void __io_poll_execute(struct io_kiocb *req, int mask)
{
io_req_set_res(req, mask, 0);
- /*
- * This is useful for poll that is armed on behalf of another
- * request, and where the wakeup path could be on a different
- * CPU. We want to avoid pulling in req->apoll->events for that
- * case.
- */
+
if (req->opcode == IORING_OP_POLL_ADD)
req->io_task_work.func = io_poll_task_func;
else
--
2.38.1
Powered by blists - more mailing lists