linux-kernel - Re: [PATCH] dmaengine: use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <102b69e4-7b1b-23ef-c4f3-a91598546c97@quicinc.com>
Date:   Thu, 10 Nov 2022 17:24:29 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     <ye.xingchen@....com.cn>, <vkoul@...nel.org>
CC:     <f.fainelli@...il.com>, <bcm-kernel-feedback-list@...adcom.com>,
        <rjui@...adcom.com>, <sbranden@...adcom.com>,
        <dmaengine@...r.kernel.org>,
        <linux-rpi-kernel@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource()

Hi,

On 11/10/2022 2:56 PM, ye.xingchen@....com.cn wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> ---
>   drivers/dma/bcm2835-dma.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 630dfbb01a40..1547f528a58e 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -902,8 +902,7 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
> 
>   	dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF);
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(&pdev->dev, res);
> +	base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>   	if (IS_ERR(base))
>   		return PTR_ERR(base);
> 

LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@...cinc.com>


-Mukesh