linux-kernel - Re: [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource()

Open Source and information security mailing list archives

Date:   Thu, 10 Nov 2022 15:43:53 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <ye.xingchen@....com.cn>, <vkoul@...nel.org>
CC:     <f.fainelli@...il.com>, <bcm-kernel-feedback-list@...adcom.com>,
        <rjui@...adcom.com>, <sbranden@...adcom.com>,
        <dmaengine@...r.kernel.org>,
        <linux-rpi-kernel@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource()

On 11/10/22 11:26, ye.xingchen@....com.cn wrote:
> [You don't often get email from ye.xingchen@....com.cn. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.

Would you review my v3 instead?
https://lore.kernel.org/lkml/20221110152528.7821-1-tudor.ambarus@microchip.com/

The intention is to do this small change for all the dma drivers in a
single patch, so that we don't pollute the commit log.

> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> ---
>  drivers/dma/bcm2835-dma.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 630dfbb01a40..1547f528a58e 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -902,8 +902,7 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
> 
>         dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF);
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       base = devm_ioremap_resource(&pdev->dev, res);
> +       base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>         if (IS_ERR(base))
>                 return PTR_ERR(base);
> 
> --
> 2.25.1
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Cheers,
ta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives