linux-kernel - Re: [PATCH v2 0/2] Balance mutex_init and mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <335b511f-ecfd-6e83-ef2e-7a74c8293b00@igalia.com>
Date:   Thu, 10 Nov 2022 11:59:54 -0100
From:   Melissa Wen <mwen@...lia.com>
To:     Maíra Canal <mcanal@...lia.com>,
        Emma Anholt <emma@...olt.net>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     André Almeida <andrealmeid@...lia.com>,
        "Juan A . Suarez" <jasuarez@...lia.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] Balance mutex_init and mutex_destroy calls


On 11/8/22 16:54, Maíra Canal wrote:
> This series introduces some changes to assure the correct resource release on
> the V3D driver, especially the mutex. Currently, the V3D has no mutex_destroy()
> calls, which means that a mutex is being instantiated, but it is not being
> released by the end of its use.
>
> So, use the DRM-managed mutex_init variants when possible to manage the mutex
> release and add mutex_destroy() calls when not possible.
>
> Best Regards,
> - Maíra Canal
>
> v1 -> v2: https://lore.kernel.org/dri-devel/20221107224656.278135-1-mcanal@igalia.com/T/#m3c23e3f21fe6aaae51138c746c74e94b2a7b3bfc
>
> - Move mutex_destroy() to v3d_perfmon_put() (Daniel Vetter).
> - Add mutex_destroy() on error case in v3d_perfmon_create_ioctl() (Daniel Vetter).
> - Add Daniel Vetter's tags.

Applied to drm-misc-next.

Thanks,

Melissa

>
> Maíra Canal (2):
>    drm/v3d: switch to drmm_mutex_init
>    drm/v3d: add missing mutex_destroy
>
>   drivers/gpu/drm/v3d/v3d_gem.c     | 17 +++++++++++++----
>   drivers/gpu/drm/v3d/v3d_perfmon.c |  6 +++++-
>   2 files changed, 18 insertions(+), 5 deletions(-)
>