linux-kernel - Re: [PATCH v2 1/2] x86: Check return values from early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66c5c5a8-7a8b-aefc-6466-c7d20236550e@suse.com>
Date:   Thu, 10 Nov 2022 17:07:44 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Ross Philipson <ross.philipson@...cle.com>,
        linux-kernel@...r.kernel.org, x86@...nel.org
Cc:     dpsmith@...rtussolutions.com, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, hpa@...or.com, luto@...capital.net,
        dave.hansen@...ux.intel.com, kanth.ghatraju@...cle.com,
        trenchboot-devel@...glegroups.com, jailhouse-dev@...glegroups.com,
        jan.kiszka@...mens.com, xen-devel@...ts.xenproject.org,
        boris.ostrovsky@...cle.com, andrew.cooper3@...rix.com
Subject: Re: [PATCH v2 1/2] x86: Check return values from early_memremap calls

On 10.11.22 16:45, Ross Philipson wrote:
> There are a number of places where early_memremap is called
> but the return pointer is not checked for NULL. The call
> can result in a NULL being returned so the checks must
> be added.
> 
> Note that the maintainers for both the Jailhouse and Xen code
> approved of using panic() to handle allocation failures.
> 
> In addition to checking the return values, a bit of extra
> cleanup of pr_* usages was done since the pr_fmt macro was
> introduced in the modules touched by this patch.
> 
> Signed-off-by: Ross Philipson <ross.philipson@...cle.com>
> ---
>   arch/x86/kernel/devicetree.c | 13 +++++++++++
>   arch/x86/kernel/e820.c       | 12 +++++++++--
>   arch/x86/kernel/jailhouse.c  |  6 ++++++
>   arch/x86/kernel/mpparse.c    | 51 +++++++++++++++++++++++++++++++++-----------
>   arch/x86/kernel/setup.c      | 19 ++++++++++++++---
>   arch/x86/xen/enlighten_hvm.c |  2 ++
>   arch/x86/xen/mmu_pv.c        |  8 +++++++
>   arch/x86/xen/setup.c         |  2 ++
>   8 files changed, 95 insertions(+), 18 deletions(-)

For the Xen parts:

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen


Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)