linux-kernel - Re: [PATCH] can: can327: fix potential skb leak when netdev is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221111010412.6ca0ff1c.max@enpas.org>
Date:   Fri, 11 Nov 2022 01:04:12 +0900
From:   Max Staudt <max@...as.org>
To:     Ziyang Xuan <william.xuanziyang@...wei.com>
Cc:     <wg@...ndegger.com>, <mkl@...gutronix.de>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <linux-can@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>
Subject: Re: [PATCH] can: can327: fix potential skb leak when netdev is down

(CC Vincent, he may be interested)


On Thu, 10 Nov 2022 14:14:37 +0800
Ziyang Xuan <william.xuanziyang@...wei.com> wrote:

> Fix it by adding kfree_skb() in can327_feed_frame_to_netdev() when netdev
> is down. Not tested, just compiled.

Looks correct to me, so:

Reviewed-by: Max Staudt <max@...as.org>


Thank you very much for finding and fixing this!

Max