linux-kernel - Re: Setting variable NULL after freeing it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOM0=daopCt=LthGStL2zHYxgQ6iphLLfKZjxcPS07yCvyq42Q@mail.gmail.com>
Date:   Sat, 12 Nov 2022 16:18:37 +0530
From:   A <amit234234234234@...il.com>
To:     Willy Tarreau <w@....eu>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: Setting variable NULL after freeing it.

>
> It depends. What's important is not to let a pointer exist to a freed
> location, so if you're doing:
>
>     kfree(card->pool);
>
> then it's usually important to follow this by:
>
>     card->pool = NULL;
>

I checked in kernel but at many places this is not being done. I can
change all that code. But, will the patch be accepted?

So, if someone is doing -

kfree(x)
._some_code_
._some_code_
._some_code_

Then I can change it to -

kfree(x)
x = NULL;
._some_code_
._some_code_
._some_code_

But, will the patch be accepted for this change?

Please let me know.

Amit