[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <cover.1668248462.git.code@siddh.me>
Date: Sat, 12 Nov 2022 16:00:39 +0530
From: Siddh Raman Pant <code@...dh.me>
To: Mauro Carvalho Chehab <mchehab@...nel.org>,
Randy Dunlap <rdunlap@...radead.org>,
David Howells <dhowells@...hat.com>,
Jonathan Corbet <corbet@....net>,
"Fabio M. De Francesco" <fmdefrancesco@...il.com>,
Eric Dumazet <edumazet@...gle.com>,
Christophe JAILLET <christophe.jaillet@...adoo.fr>,
Eric Biggers <ebiggers@...nel.org>
Cc: keyrings <keyrings@...r.kernel.org>,
linux-security-module <linux-security-module@...r.kernel.org>,
linux-fsdevel <linux-fsdevel@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: [RESEND PATCH v2 0/2] watch_queue: Clean up some code
There is a dangling reference to pipe in a watch_queue after clearing it.
Thus, NULL that pointer while clearing.
This change renders wqueue->defunct superfluous, as the latter is only used
to check if watch_queue is cleared. With this change, the pipe is NULLed
while clearing, so we can just check if the pipe is NULL.
Extending comment for watch_queue->pipe in the definition of watch_queue
made the comment conventionally too long (it was already past 80 chars),
so I have changed the struct annotations to be kerneldoc-styled, so that
I can extend the comment mentioning that the pipe is NULL when watch_queue
is cleared. In the process, I have also hopefully improved documentation
by documenting things which weren't documented before.
Changes in v2:
- Merged the NULLing and removing defunct patches.
- Removed READ_ONCE barrier in lock_wqueue().
- Improved and fixed errors in struct docs.
- Better commit messages.
Original date of posting patch: 6 Aug 2022
Siddh Raman Pant (2):
include/linux/watch_queue: Improve documentation
kernel/watch_queue: NULL the dangling *pipe, and use it for clear
check
include/linux/watch_queue.h | 100 ++++++++++++++++++++++++++----------
kernel/watch_queue.c | 12 ++---
2 files changed, 79 insertions(+), 33 deletions(-)
--
2.35.1
Powered by blists - more mailing lists