linux-kernel - Re: [PATCH v2 1/3] gpio:gpio-npcm-sgpio: Add Nuvoton sgpio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 13 Nov 2022 06:52:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jim Liu <jim.t90615@...il.com>, JJLIU0@...oton.com,
        KWLIU@...oton.com, linus.walleij@...aro.org, brgl@...ev.pl,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, openbmc@...ts.ozlabs.org
Subject: Re: [PATCH v2 1/3] gpio:gpio-npcm-sgpio: Add Nuvoton sgpio driver

Hi Jim,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on brgl/gpio/for-next]
[also build test ERROR on robh/for-next linus/master v6.1-rc4 next-20221111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jim-Liu/Support-Nuvoton-NPCM750-SGPIO/20221108-173059
base:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link:    https://lore.kernel.org/r/20221108092840.14945-2-JJLIU0%40nuvoton.com
patch subject: [PATCH v2 1/3] gpio:gpio-npcm-sgpio: Add Nuvoton sgpio driver
config: arm64-allmodconfig
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 463da45892e2d2a262277b91b96f5f8c05dc25d0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/cd75b3ccf74c156e0116e57fc76169afd9f2163a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jim-Liu/Support-Nuvoton-NPCM750-SGPIO/20221108-173059
        git checkout cd75b3ccf74c156e0116e57fc76169afd9f2163a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/gpio/ drivers/gpu/drm/amd/amdkfd/ drivers/pinctrl/ sound/soc/codecs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/gpio/gpio-npcm-sgpio.c:148:10: error: incompatible integer to pointer conversion returning 'int' from a function with result type 'void *' [-Wint-conversion]
                   return -EINVAL;
                          ^~~~~~~
   1 error generated.


vim +148 drivers/gpio/gpio-npcm-sgpio.c

   131	
   132	static void __iomem *bank_reg(struct npcm_sgpio *gpio,
   133				      const struct npcm_sgpio_bank *bank,
   134					const enum npcm_sgpio_reg reg)
   135	{
   136		switch (reg) {
   137		case READ_DATA:
   138			return gpio->base + bank->rdata_reg;
   139		case WRITE_DATA:
   140			return gpio->base + bank->wdata_reg;
   141		case EVENT_CFG:
   142			return gpio->base + bank->event_config;
   143		case EVENT_STS:
   144			return gpio->base + bank->event_status;
   145		default:
   146			/* acturally if code runs to here, it's an error case */
   147			WARN(1, "NPCM SGPIO REG SET failed!!\n");
 > 148			return -EINVAL;
   149		}
   150	}
   151	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (355166 bytes)