lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 12 Nov 2022 23:59:38 +0100 From: Martin Blumenstingl <martin.blumenstingl@...glemail.com> To: Vyacheslav Bocharov <adeep@...ina.in> Cc: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/4] arm64: amlogic: mmc: meson-gx: Add dts binding include for core, tx, rx eMMC/SD/SDIO phase clock settings from devicetree data Hi Vyacheslav, On Thu, Nov 10, 2022 at 4:02 PM Vyacheslav Bocharov <adeep@...ina.in> wrote: [...] > +/* > + * Cfg_rx_phase: RX clock phase > + * bits: 9:8 R/W Generally register values should not be part of the dt-bindings. If we need to make the phases configurable through device-tree then I suggest using the human readable values (0, 90, 180, 270) instead of these register bits. That said, if for whatever reason we need to have #defines for this then they should be added with the dt-bindings patch (and also carry the dt-bindings subject prefix) instead of a separate patch. Best regards, Martin
Powered by blists - more mailing lists