lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACPK8XfyOCmr_mRmaGTG6oJUNwU23ZoWam0e-RrQxY38=OnVrQ@mail.gmail.com> Date: Mon, 14 Nov 2022 03:16:00 +0000 From: Joel Stanley <joel@....id.au> To: Eddie James <eajames@...ux.ibm.com> Cc: linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org, Alexander.Steffen@...ineon.com, jgg@...pe.ca, jarkko@...nel.org, peterhuewe@....de Subject: Re: [PATCH] tpm: tis_i2c: Fix sanity check interrupt enable mask On Wed, 17 Aug 2022 at 20:03, Eddie James <eajames@...ux.ibm.com> wrote: > > The sanity check mask for TPM_INT_ENABLE register was off by 8 bits, > resulting in failure to probe if the TPM_INT_ENABLE register was a > valid value. > > Fixes: bbc23a07b072 ("tpm: Add tpm_tis_i2c backend for tpm_tis_core") > Signed-off-by: Eddie James <eajames@...ux.ibm.com> Tested-by: Joel Stanley <joel@....id.au> Fixes: bbc23a07b072 ("tpm: Add tpm_tis_i2c backend for tpm_tis_core") Jarkko, do you plan on sending this as a fix? > --- > drivers/char/tpm/tpm_tis_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c > index 0692510dfcab..635a69dfcbbd 100644 > --- a/drivers/char/tpm/tpm_tis_i2c.c > +++ b/drivers/char/tpm/tpm_tis_i2c.c > @@ -49,7 +49,7 @@ > > /* Masks with bits that must be read zero */ > #define TPM_ACCESS_READ_ZERO 0x48 > -#define TPM_INT_ENABLE_ZERO 0x7FFFFF6 > +#define TPM_INT_ENABLE_ZERO 0x7FFFFF60 > #define TPM_STS_READ_ZERO 0x23 > #define TPM_INTF_CAPABILITY_ZERO 0x0FFFF000 > #define TPM_I2C_INTERFACE_CAPABILITY_ZERO 0x80000000 > -- > 2.31.1 >
Powered by blists - more mailing lists