lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Nov 2022 15:31:20 +0000 From: Shenwei Wang <shenwei.wang@....com> To: Alexander Lobakin <alexandr.lobakin@...el.com> CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, Wei Fang <wei.fang@....com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>, kernel test robot <lkp@...el.com> Subject: RE: [EXT] Re: [PATCH v3 1/1] net: fec: add xdp and page pool statistics > -----Original Message----- > From: Alexander Lobakin <alexandr.lobakin@...el.com> > Sent: Monday, November 14, 2022 9:28 AM > To: Shenwei Wang <shenwei.wang@....com> > Cc: Alexander Lobakin <alexandr.lobakin@...el.com>; David S. Miller > <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub > Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Alexei > Starovoitov <ast@...nel.org>; Daniel Borkmann <daniel@...earbox.net>; > Jesper Dangaard Brouer <hawk@...nel.org>; John Fastabend > <john.fastabend@...il.com>; Wei Fang <wei.fang@....com>; > netdev@...r.kernel.org; linux-kernel@...r.kernel.org; imx@...ts.linux.dev; > kernel test robot <lkp@...el.com> > > > <daniel@...earbox.net>; > > >> @@ -29,6 +29,7 @@ config FEC > > >> select CRC32 > > >> select PHYLIB > > >> select PAGE_POOL > > >> + select PAGE_POOL_STATS > > > > > > Drivers should never select PAGE_POOL_STATS. This Kconfig option was > > > made to allow user to choose whether he wants stats or better > > > performance on slower systems. It's pure user choice, if something > > > doesn't build or link, it must be guarded with > IS_ENABLED(CONFIG_PAGE_POOL_STATS). > > > > As the PAGE_POOL_STATS is becoming the infrastructure codes for many > > drivers, it is redundant for every driver to implement the stub > > function in case it is not selected. These stub functions should be provided by > PAGE_POOL_STATS itself if the option is not selected. > > Correct, but I think you added 'select PAGE_POOL_STATS' due to some build > issues on PPC64, or not? So if there are any when !PAGE_POOL_STATS, it's > always better to handle this at the Page Pool API level in a separate patch. Yes, the 'select PAGE_POOL_STATS' was added because of the building failure found on PPC64 platform. Thanks, Shenwei > > > > > > > > >> imply NET_SELFTESTS > > >> help > > >> Say Y here if you want to use the built-in 10/100 Fast > > Thanks, > Olek
Powered by blists - more mailing lists