| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACGkMEupWx6YZToNqxyJ9sD5v41ouOeKe2=0_ASbWPFt8s1uGA@mail.gmail.com>
Date: Mon, 14 Nov 2022 12:41:10 +0800
From: Jason Wang <jasowang@...hat.com>
To: Eli Cohen <elic@...dia.com>
Cc: mst@...hat.com, linux-kernel@...r.kernel.org,
virtualization@...ts.linux-foundation.org, si-wei.liu@...cle.com,
eperezma@...hat.com, lulu@...hat.com
Subject: Re: [PATCH 3/7] vdpa/mlx5: Move some definitions to a new header file
On Sun, Nov 13, 2022 at 9:45 PM Eli Cohen <elic@...dia.com> wrote:
>
> Move some definitions from mlx5_vnet.c to newly added header file
> mlx5_vnet.h. We need these definitions for the following patches that
> add debugfs tree to expose information vital for debug.
>
> Reviewed-by: Si-Wei Liu <si-wei.liu@...cle.com>
> Signed-off-by: Eli Cohen <elic@...dia.com>
Acked-by: Jason Wang <jasowang@...hat.com>
Thanks
> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 45 +------------------------
> drivers/vdpa/mlx5/net/mlx5_vnet.h | 55 +++++++++++++++++++++++++++++++
> 2 files changed, 56 insertions(+), 44 deletions(-)
> create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index c54d5088ed4f..e45b83527b41 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -18,15 +18,12 @@
> #include <linux/mlx5/mlx5_ifc_vdpa.h>
> #include <linux/mlx5/mpfs.h>
> #include "mlx5_vdpa.h"
> +#include "mlx5_vnet.h"
>
> MODULE_AUTHOR("Eli Cohen <eli@...lanox.com>");
> MODULE_DESCRIPTION("Mellanox VDPA driver");
> MODULE_LICENSE("Dual BSD/GPL");
>
> -#define to_mlx5_vdpa_ndev(__mvdev) \
> - container_of(__mvdev, struct mlx5_vdpa_net, mvdev)
> -#define to_mvdev(__vdev) container_of((__vdev), struct mlx5_vdpa_dev, vdev)
> -
> #define VALID_FEATURES_MASK \
> (BIT_ULL(VIRTIO_NET_F_CSUM) | BIT_ULL(VIRTIO_NET_F_GUEST_CSUM) | \
> BIT_ULL(VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) | BIT_ULL(VIRTIO_NET_F_MTU) | BIT_ULL(VIRTIO_NET_F_MAC) | \
> @@ -50,14 +47,6 @@ MODULE_LICENSE("Dual BSD/GPL");
>
> #define MLX5V_UNTAGGED 0x1000
>
> -struct mlx5_vdpa_net_resources {
> - u32 tisn;
> - u32 tdn;
> - u32 tirn;
> - u32 rqtn;
> - bool valid;
> -};
> -
> struct mlx5_vdpa_cq_buf {
> struct mlx5_frag_buf_ctrl fbc;
> struct mlx5_frag_buf frag_buf;
> @@ -146,38 +135,6 @@ static bool is_index_valid(struct mlx5_vdpa_dev *mvdev, u16 idx)
> return idx <= mvdev->max_idx;
> }
>
> -#define MLX5V_MACVLAN_SIZE 256
> -
> -struct mlx5_vdpa_net {
> - struct mlx5_vdpa_dev mvdev;
> - struct mlx5_vdpa_net_resources res;
> - struct virtio_net_config config;
> - struct mlx5_vdpa_virtqueue *vqs;
> - struct vdpa_callback *event_cbs;
> -
> - /* Serialize vq resources creation and destruction. This is required
> - * since memory map might change and we need to destroy and create
> - * resources while driver in operational.
> - */
> - struct rw_semaphore reslock;
> - struct mlx5_flow_table *rxft;
> - bool setup;
> - u32 cur_num_vqs;
> - u32 rqt_size;
> - bool nb_registered;
> - struct notifier_block nb;
> - struct vdpa_callback config_cb;
> - struct mlx5_vdpa_wq_ent cvq_ent;
> - struct hlist_head macvlan_hash[MLX5V_MACVLAN_SIZE];
> -};
> -
> -struct macvlan_node {
> - struct hlist_node hlist;
> - struct mlx5_flow_handle *ucast_rule;
> - struct mlx5_flow_handle *mcast_rule;
> - u64 macvlan;
> -};
> -
> static void free_resources(struct mlx5_vdpa_net *ndev);
> static void init_mvqs(struct mlx5_vdpa_net *ndev);
> static int setup_driver(struct mlx5_vdpa_dev *mvdev);
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.h b/drivers/vdpa/mlx5/net/mlx5_vnet.h
> new file mode 100644
> index 000000000000..6691c879a6ca
> --- /dev/null
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.h
> @@ -0,0 +1,55 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB */
> +/* Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. All rights reserved. */
> +
> +#ifndef __MLX5_VNET_H__
> +#define __MLX5_VNET_H__
> +
> +#include "mlx5_vdpa.h"
> +
> +#define to_mlx5_vdpa_ndev(__mvdev) \
> + container_of(__mvdev, struct mlx5_vdpa_net, mvdev)
> +#define to_mvdev(__vdev) container_of((__vdev), struct mlx5_vdpa_dev, vdev)
> +
> +struct mlx5_vdpa_net_resources {
> + u32 tisn;
> + u32 tdn;
> + u32 tirn;
> + u32 rqtn;
> + bool valid;
> +};
> +
> +#define MLX5V_MACVLAN_SIZE 256
> +
> +struct mlx5_vdpa_net {
> + struct mlx5_vdpa_dev mvdev;
> + struct mlx5_vdpa_net_resources res;
> + struct virtio_net_config config;
> + struct mlx5_vdpa_virtqueue *vqs;
> + struct vdpa_callback *event_cbs;
> +
> + /* Serialize vq resources creation and destruction. This is required
> + * since memory map might change and we need to destroy and create
> + * resources while driver in operational.
> + */
> + struct rw_semaphore reslock;
> + struct mlx5_flow_table *rxft;
> + struct dentry *rx_dent;
> + struct dentry *rx_table_dent;
> + bool setup;
> + u32 cur_num_vqs;
> + u32 rqt_size;
> + bool nb_registered;
> + struct notifier_block nb;
> + struct vdpa_callback config_cb;
> + struct mlx5_vdpa_wq_ent cvq_ent;
> + struct hlist_head macvlan_hash[MLX5V_MACVLAN_SIZE];
> +};
> +
> +struct macvlan_node {
> + struct hlist_node hlist;
> + struct mlx5_flow_handle *ucast_rule;
> + struct mlx5_flow_handle *mcast_rule;
> + u64 macvlan;
> +};
> +
> +#endif /* __MLX5_VNET_H__ */
> --
> 2.38.1
>
Powered by blists - more mailing lists