linux-kernel - Re: [net] net: usb: smsc95xx: fix external PHY reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3InKCr9BGaf8wiI@shell.armlinux.org.uk>
Date:   Mon, 14 Nov 2022 11:31:52 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Alexandru Tachici <alexandru.tachici@...log.com>
Cc:     linux-kernel@...r.kernel.org, andrew@...n.ch, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, steve.glendinning@...well.net,
        UNGLinuxDriver@...rochip.com, andre.edich@...rochip.com,
        linux-usb@...r.kernel.org
Subject: Re: [net] net: usb: smsc95xx: fix external PHY reset

On Mon, Nov 14, 2022 at 03:16:43PM +0200, Alexandru Tachici wrote:
> +	} else {
> +		/* Driver has no knowledge at this point about the external PHY.
> +		 * The 802.3 specifies that the reset process shall
> +		 * be completed within 0.5 s.
> +		 */
> +		fsleep(500000);
> +	}

It's slightly more code, but would it be better to do this in the
mdiobus reset() method?

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!