linux-kernel - Re: [net] net: usb: smsc95xx: fix external PHY reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <adb2dc3c-fd1e-53ea-ca64-5c1600058890@gmail.com>
Date:   Mon, 14 Nov 2022 14:43:22 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Alexandru Tachici <alexandru.tachici@...log.com>,
        linux-kernel@...r.kernel.org
Cc:     andrew@...n.ch, linux@...linux.org.uk, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, steve.glendinning@...well.net,
        UNGLinuxDriver@...rochip.com, andre.edich@...rochip.com,
        linux-usb@...r.kernel.org
Subject: Re: [net] net: usb: smsc95xx: fix external PHY reset

Hello!

On 11/14/22 4:16 PM, Alexandru Tachici wrote:

> An external PHY needs settling time after power up or reser.

   Reset? :-)

> In the bind() function an mdio bus is registered. If at this point
> the external PHY is still initialising, no valid PHY ID will be
> read and on phy_find_first() the bind() function will fail.
> 
> If an external PHY is present, wait the maximum time specified
> in 802.3 45.2.7.1.1.
> 
> Fixes: 05b35e7eb9a1 ("smsc95xx: add phylib support")
> Signed-off-by: Alexandru Tachici <alexandru.tachici@...log.com>

[...]

MBR, Sergey