linux-kernel - Re: [PATCH 05/18] mfd: max14577: Replace irqchip mask_invert with unmask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3JKkmd9FRnwTg91@google.com>
Date:   Mon, 14 Nov 2022 14:02:58 +0000
From:   Lee Jones <lee@...nel.org>
To:     Aidan MacDonald <aidanmacdonald.0x0@...il.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        mani@...nel.org, cristian.ciocaltea@...il.com, wens@...e.org,
        tharvey@...eworks.com, cw00.choi@...sung.com, brgl@...ev.pl,
        mazziesaccount@...il.com, orsonzhai@...il.com,
        baolin.wang@...ux.alibaba.com, zhang.lyra@...il.com,
        jernej.skrabec@...il.com, samuel@...lland.org,
        linux-kernel@...r.kernel.org, linux-actions@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH 05/18] mfd: max14577: Replace irqchip mask_invert with
 unmask_base

On Mon, 14 Nov 2022, Aidan MacDonald wrote:

> 
> Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> writes:
> 
> > On 12/11/2022 16:18, Aidan MacDonald wrote:
> >> Remove use of the deprecated mask_invert flag. Inverted mask
> >> registers (where a '1' bit enables an IRQ) can be described more
> >> directly as an unmask register.
> >>
> >> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@...il.com>
> >> ---
> >>  drivers/mfd/max14577.c | 7 ++-----
> >>  1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > Mention this is a resend or provide a changelog for v2.
> 
> Most of these patches are resends, but they're so trivial it seems
> pointless to mention that fact. There are no changes from v1.

How are people supposed to know the difference between "no change"
and "there have been lots of changes, but I forgot to add a
change-log"? :)

Nothing wrong with:

v1 -> v2:
  No code changes

> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >
> > Best regards,
> > Krzysztof

-- 
Lee Jones [李琼斯]