linux-kernel - Re: [PATCH] usb: phy: add dedicated notifier for charger events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221114140343.GK10437@ediswmail.ad.cirrus.com>
Date:   Mon, 14 Nov 2022 14:03:43 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
CC:     <sre@...nel.org>, <orsonzhai@...il.com>,
        <baolin.wang@...ux.alibaba.com>, <zhang.lyra@...il.com>,
        <gregkh@...uxfoundation.org>, <felipe.balbi@...ux.intel.com>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <patches@...nsource.cirrus.com>, <linux-usb@...r.kernel.org>,
        <tony@...mide.com>
Subject: Re: [PATCH] usb: phy: add dedicated notifier for charger events

On Mon, Nov 14, 2022 at 02:56:02PM +0200, Ivaylo Dimitrov wrote:
> usb_phy::notifier is already used by various PHY drivers (including
> phy_generic) to report VBUS status changes and its usage conflicts with
> charger current limit changes reporting.
> 
> Fix that by introducing a second notifier that is dedicated to usb charger
> notifications. Add usb_charger_XXX_notifier functions. Fix charger drivers
> that currently (ab)use usb_XXX_notifier() to use the new API.
> 
> Fixes: a9081a008f84 ("usb: phy: Add USB charger support")
> 
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
> ---
>  drivers/power/supply/wm831x_power.c   |  7 ++++---

For the changes to wm831x looks fine to me:

Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles