linux-kernel - Re: [PATCH v3 03/14] serial: liteuart: remove unused uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Nov 2022 17:37:22 +0200 (EET)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Gabriel Somlo <gsomlo@...il.com>
cc:     LKML <linux-kernel@...r.kernel.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>, kgugala@...micro.com,
        mholenko@...micro.com, joel@....id.au,
        david.abdurachmanov@...il.com, florent@...oy-digital.fr,
        geert@...ux-m68k.org
Subject: Re: [PATCH v3 03/14] serial: liteuart: remove unused uart_ops
 stubs

On Sat, 12 Nov 2022, Gabriel Somlo wrote:

> Remove stub uart_ops methods that are not called unconditionally
> from serial_core. Document stubs that are expected to be present.
> 
> Signed-off-by: Gabriel Somlo <gsomlo@...il.com>
> ---
>  drivers/tty/serial/liteuart.c | 18 +-----------------
>  1 file changed, 1 insertion(+), 17 deletions(-)
> 
> diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
> index 1497d4cdc221..90f6280c5452 100644
> --- a/drivers/tty/serial/liteuart.c
> +++ b/drivers/tty/serial/liteuart.c
> @@ -122,6 +122,7 @@ static unsigned int liteuart_get_mctrl(struct uart_port *port)
>  
>  static void liteuart_stop_tx(struct uart_port *port)
>  {
> +	/* not used in LiteUART, but called unconditionally from serial_core */
>  }
>  
>  static void liteuart_start_tx(struct uart_port *port)
> @@ -154,11 +155,6 @@ static void liteuart_stop_rx(struct uart_port *port)
>  	del_timer(&uart->timer);
>  }
>  
> -static void liteuart_break_ctl(struct uart_port *port, int break_state)
> -{
> -	/* LiteUART doesn't support sending break signal */
> -}
> -
>  static int liteuart_startup(struct uart_port *port)
>  {
>  	struct liteuart_port *uart = to_liteuart_port(port);
> @@ -197,15 +193,6 @@ static const char *liteuart_type(struct uart_port *port)
>  	return "liteuart";
>  }
>  
> -static void liteuart_release_port(struct uart_port *port)
> -{
> -}
> -
> -static int liteuart_request_port(struct uart_port *port)
> -{
> -	return 0;
> -}
> -
>  static void liteuart_config_port(struct uart_port *port, int flags)
>  {
>  	/*
> @@ -232,13 +219,10 @@ static const struct uart_ops liteuart_ops = {
>  	.stop_tx	= liteuart_stop_tx,
>  	.start_tx	= liteuart_start_tx,
>  	.stop_rx	= liteuart_stop_rx,
> -	.break_ctl	= liteuart_break_ctl,
>  	.startup	= liteuart_startup,
>  	.shutdown	= liteuart_shutdown,
>  	.set_termios	= liteuart_set_termios,
>  	.type		= liteuart_type,
> -	.release_port	= liteuart_release_port,
> -	.request_port	= liteuart_request_port,
>  	.config_port	= liteuart_config_port,
>  	.verify_port	= liteuart_verify_port,
>  };
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>


-- 
 i.