[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fd1b8455-47eb-3161-4076-136e3265155@linux.intel.com>
Date: Tue, 15 Nov 2022 17:38:12 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Gabriel Somlo <gsomlo@...il.com>
cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
gregkh@...uxfoundation.org, jirislaby@...nel.org,
kgugala@...micro.com, mholenko@...micro.com, joel@....id.au,
david.abdurachmanov@...il.com, florent@...oy-digital.fr,
geert@...ux-m68k.org
Subject: Re: [PATCH v3 06/14] serial: liteuart: move tty_flip_buffer_push()
out of rx loop
On Sat, 12 Nov 2022, Gabriel Somlo wrote:
> Calling tty_flip_buffer_push() for each individual received character
> is overkill. Move it out of the rx loop, and only call it once per
> set of characters received together.
>
> Signed-off-by: Gabriel Somlo <gsomlo@...il.com>
> ---
> drivers/tty/serial/liteuart.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
> index 047d5ad32e13..ff3486860989 100644
> --- a/drivers/tty/serial/liteuart.c
> +++ b/drivers/tty/serial/liteuart.c
> @@ -86,10 +86,10 @@ static void liteuart_timer(struct timer_list *t)
> /* no overflow bits in status */
> if (!(uart_handle_sysrq_char(port, ch)))
> uart_insert_char(port, status, 0, ch, flg);
> -
> - tty_flip_buffer_push(&port->state->port);
> }
>
> + tty_flip_buffer_push(&port->state->port);
> +
> mod_timer(&uart->timer, jiffies + uart_poll_timeout(port));
> }
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
--
i.
Powered by blists - more mailing lists